-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: factory flow with a devfile that uses a parent #1320
Conversation
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1320 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1320", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1320 +/- ##
==========================================
+ Coverage 91.81% 91.82% +0.01%
==========================================
Files 501 501
Lines 45478 45476 -2
Branches 3192 3185 -7
==========================================
+ Hits 41754 41760 +6
+ Misses 3688 3683 -5
+ Partials 36 33 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olexii4 would it be possible to add some test coverage for the parentDevfile functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eclipse Che Next with User Dashboard quay.io/eclipse/che-dashboard:pr-1320 has successfully created workspace using Git Repo with parent devfile https://github.com/testsfactory/parentDevfile
Screencast:
screen-capture (3).webm
Well done!
Signed-off-by: Oleksii Orel <[email protected]>
Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1320 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1320", name: che-dashboard}]}}]" |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dmytro-ndp, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.20 :: dashboard_3.x/632: Console, Changes, Git Data |
Build 3.20 :: sync-to-downstream_3.x/8835: Console, Changes, Git Data |
What does this PR do?
This PR fixes factory flow with a devfile that uses a parent.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23353
Is it tested? How?
Release Notes
Docs PR